From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F2E94469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  5 Jun 2020 22:21:27 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id x27so6453131lfg.9
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 05 Jun 2020 12:21:27 -0700 (PDT)
Date: Fri, 5 Jun 2020 22:21:24 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200605192124.GA2094@grain>
References: <20200605185544.54436-1-gorcunov@gmail.com>
 <c7402855-f5a3-b7e4-ba66-79a2e39ce39c@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c7402855-f5a3-b7e4-ba66-79a2e39ce39c@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to
 setup logger without box.cfg{}
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, Jun 05, 2020 at 10:14:51PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patchset. I think this series should be pushed - LGTM.
> However I have several comments:
>   - Don't forget to file an issue to rework approarch to module
> configuratoin and remove dead code (I suppose that functions
> private.cfg_set_log_level and private.cfg_set_log_format will be unused
> after that);
>   - It would be nice to add tests from your previous series where you test
> possibility to pass string as log level.

Yes. I've a plan to address all this. Next week. Thanks!