From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 47B3A469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  5 Jun 2020 09:55:38 +0300 (MSK)
Date: Fri, 5 Jun 2020 09:55:21 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200605065521.i3k3dw7xmsejdysm@tkn_work_nb>
References: <20200429122038.53296-1-arkholga@tarantool.org>
 <20200527160242.akqs35kka34fj2cb@tkn_work_nb>
 <20200604215103.GK5745@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200604215103.GK5745@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance
	in postinstall
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org

> Long story short: comparing both approaches I personally prefer to apply
> the one from the origin patch and take some changes you provided below
> (e.g. empty <enabled> directory handling).
> 
> I also Cced Yaroslav as the person who faced the issue "for several
> times across these years".

I don't mind any of these approaches. I don't know which one would be
better. So I would say that I have no preference for one over another.

> AFAICS, there are some files left on the system after this "migration"
> that are not tracked by the package. So they are not removed anymore
> even after the package is deinstalled.

They will not be removed at `apt-get remove`, but will be at `apt-get
purge` as well as everything in /etc/tarantool. See:

 | $ cat debian/tarantool-common.postrm 
 | #!/bin/sh
 |
 | set -e
 |
 | case "$1" in
 |     purge)
 |         rm -fr  \
 |             /etc/tarantool \
 |             /var/log/tarantool \
 |             /var/run/tarantool \
 |             /var/lib/tarantool
 |     ;;
 | esac
 |
 | #DEBHELPER#