From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 947D4469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  4 Jun 2020 02:22:07 +0300 (MSK)
Date: Thu, 4 Jun 2020 02:12:59 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200603231259.GH5745@tarantool.org>
References: <cover.1589321083.git.alexander.turenko@tarantool.org>
 <3c0d131898ba3b78c2f36fa82873b78dbf707df6.1589321083.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3c0d131898ba3b78c2f36fa82873b78dbf707df6.1589321083.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/3] box: always wait box loading in
	box.execute()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch! It LGTM, but is "blocked" since it strongly
depends on the previous one.

On 13.05.20, Alexander Turenko wrote:
> <box_load_and_execute> checks whether box is configured with appropriate
> locking and configures it when necessary. However it is not so for
> <lbox_execute>. We should replace the former with the latter only when
> box is fully loaded.
> 
> Follow-up #4231
> ---
>  src/box/lua/load_cfg.lua                      | 20 ++++++++++++---
>  .../gh-4231-box-execute-locking.test.lua      | 25 ++++++++++++++++++-
>  test/box-tap/suite.cfg                        |  6 +++++
>  test/box-tap/suite.ini                        |  1 +
>  4 files changed, 48 insertions(+), 4 deletions(-)
>  create mode 100644 test/box-tap/suite.cfg
> 

<snipped>

> -- 
> 2.25.0
> 

-- 
Best regards,
IM