From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ECF53469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  3 Jun 2020 15:29:48 +0300 (MSK)
Date: Wed, 3 Jun 2020 15:29:32 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200603122932.qxwmu65xmkvcovcv@tkn_work_nb>
References: <863e5ca812384f62cc573f96b1b314fe87a0b86d.1589999586.git.avtikhon@tarantool.org>
 <20200601123950.fj2c3tjza7hbksf6@tkn_work_nb>
 <20200602175642.GA4599@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200602175642.GA4599@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v1] Set full testing for all branches
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I have no more objections.

If everything works as expected and we're ready to such amount of jobs,
the change will allow to catch some problems before a patch will land
into master.

BTW, please add 'gitlab-ci' prefix.

> > >  .pack_only_template: &pack_only_definition
> > >    only:
> > >      - schedules
> > >      - external_pull_requests
> > >      - merge_requests
> > > -    - /^.*-full-ci$/
> > > +    - branches
> > > +    - tags
> > 
> > First, there is not reason to list 'schedules', 'external_pull_requests'
> > and so if you want to just run it everywhere.
> > 
> 
> Actually I just wanted to make it more visible for the users, but anyway
> if it not really needed I'll change it to "except: master".
> 
> > Second, we should not run both 'just packaging' and 'packaging and
> > deployment' jobs on master. I would make ''pack_only_template' be just
> > 'except: master'. Yep, it is not perfect: 'schedules',
> > 'external_pull_requests' will don't run neither 'pack', nor 'deploy'.
> > But this change is simple and downsides are acceptable.
> > 
> 
> Right, it is the same as previous my comment.

I would mention the known downside somewhere, preferably just in this
config.