From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5452A469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  3 Jun 2020 14:37:51 +0300 (MSK)
Date: Wed, 3 Jun 2020 14:37:49 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200603113749.GA7229@hpalx>
References: <3cc793c75b3e5e3ea58c607778aac4fc74ba784a.1590901924.git.avtikhon@tarantool.org>
 <20200601104756.7kxdl5kmlzn3gonm@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200601104756.7kxdl5kmlzn3gonm@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at
	pwd.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Alexander, thanks for the review, I've changed it as you suggested.

On Mon, Jun 01, 2020 at 01:47:56PM +0300, Alexander Turenko wrote:
> On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> > During investigation of the issues found that error message had
> > not user friendly format:
> >  local pwgr_errstr = "get%s failed [errno %d]: %s"
> > produced:
> >  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> > while it had to be:
> >  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> > Fixed the error message.
> 
> My bad, looks as regression from
> 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
> from deserialization').
> 
> LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
> or directory', without leading 'get'.
> 
> WBR, Alexander Turenko.