From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 35753469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 19:57:16 +0300 (MSK)
Date: Tue, 2 Jun 2020 19:57:14 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200602165714.GC50@tarantool.org>
References: <20200602121949.20254-1-skaplun@tarantool.org>
 <20200602135140.GC5745@tarantool.org> <20200602141636.GA8942@root>
 <20200602141303.GD5745@tarantool.org> <20200602150104.GA14098@root>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200602150104.GA14098@root>
Subject: Re: [Tarantool-patches] [PATCH v2] lua: remove excess Lua call from
 table encoding
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi!

Thanks for the patch!

Still I would like to see some tests - perhaps with errinj to emulate
OOM or some other case that trigger the 'excess protected frame' need.
So that after your changes it still passes.

Regards,
Sergos


On 02 июн 18:01, Sergey Kaplun wrote:
> On 02.06.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Nice. Almost forgot: please also provide a ChangeLog entry.
> 
> @Changelog:
>  * Refactor Lua table encoding: removed excess Lua function object and
> protected Lua frame creation to improve `msgpack.encode()` performance.
> 
> > 
> > On 02.06.20, Sergey Kaplun wrote:
> > > Hi! Thanks for the review!
> > > 
> > 
> > <snipped>
> > 
> > > 
> > > -- 
> > > Best regards,
> > > Sergey Kaplun
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun