From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AC79F469710 for ; Tue, 2 Jun 2020 17:54:11 +0300 (MSK) Date: Tue, 2 Jun 2020 17:54:08 +0300 From: Kirill Yukhin Message-ID: <20200602145408.mg3n6jdrcfayn267@tarantool.org> References: <5f4f3b47886fa74ab4c8fa19cbe77d80ed67b4b6.1589918392.git.lvasiliev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f4f3b47886fa74ab4c8fa19cbe77d80ed67b4b6.1589918392.git.lvasiliev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH V2] socket: fix error while closing socket.tcp_server List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org Hello, On 19 май 23:05, Leonid Vasiliev wrote: > The tcp server starts in a separate fiber. > When server's socket is closed from another fiber, > an exception will be thrown in server's loop from > check_socket function. > A "socket is close" check has been added at server's > fiber and now server's fiber terminates correctly. > > Fixes: #4087 LGTM. I've checked your patch into 1.10, 2.3, 2.4 and master. -- Regards, Kirill Yukhin