From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 15550469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 14:56:41 +0300 (MSK)
Date: Tue, 2 Jun 2020 14:56:24 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200602115624.5maxpuofeejas347@tkn_work_nb>
References: <1dde0d093dc53b6a7819780b11801ae1ceba04ca.1589814593.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1dde0d093dc53b6a7819780b11801ae1ceba04ca.1589814593.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] Add new error injection constant
	ERRINJ_AUTO_UPGRADE
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On Mon, May 18, 2020 at 06:10:06PM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> In upgrade testing we need an ability to control running of upgrade.lua
> script execution. When constant ERRINJ_AUTO_UPGRADE is set to true
> tarantool will skip upgrade.lua script execution.
> 
> Part of: #4801
> ---
> GH issue: https://github.com/tarantool/tarantool/issues/4801
> GH branch: https://github.com/tarantool/tarantool/compare/ligurio/gh-4801-errinj_auto_upgrade

LGTM.

Don't think more reviews are needed here, the patch is simple.

CCed Kirill.

WBR, Alexander Turenko.