From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CF7BA469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 11:15:33 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id u10so10241166ljj.9
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 02 Jun 2020 01:15:33 -0700 (PDT)
Date: Tue, 2 Jun 2020 11:15:31 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200602081531.GA568636@grain>
References: <20200601222507.560415-1-gorcunov@gmail.com>
 <20200601222507.560415-8-gorcunov@gmail.com>
 <7df84b33-6069-10e5-311c-98058e11cacf@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7df84b33-6069-10e5-311c-98058e11cacf@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 07/11] lua/log: use log module
	settings inside box.cfg
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Tue, Jun 02, 2020 at 10:51:28AM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch.
> 
> I've found a strange case:
> ```
> tarantool> log.cfg({log = '1.txt'})
> ---
> ...
> 
> tarantool> log.cfg({log = '2.txt'}) -- error - OK
> ---
> - error: 'builtin/log.lua:273: log: ''log'' can''t be set dynamically'
> ...
> 
> tarantool> box.cfg{log = '2.txt'} -- no error (why?)
> ---
> ...
> 
> tarantool> log.error('test')
> ---
> ...
> ```
> 
> log.cfg and box.cfg shows:
> ```
> tarantool> log.cfg.log
> ---
> - 2.txt
> ...
> 
> tarantool> box.cfg.log
> ---
> - 2.txt
> ...
> ```
> 
> But actually "1.txt" is my log file.
> Also I suggest to cover such situation with a test :)

Good catch! Yes, I need to revisit this moment. Thanks!!!