From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com
 [209.85.208.177])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8C462469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 11:12:44 +0300 (MSK)
Received: by mail-lj1-f177.google.com with SMTP id z9so795978ljh.13
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 02 Jun 2020 01:12:44 -0700 (PDT)
Date: Tue, 2 Jun 2020 11:12:41 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200602081241.GT215590@grain>
References: <20200601222507.560415-1-gorcunov@gmail.com>
 <20200601222507.560415-11-gorcunov@gmail.com>
 <220cea35-47f1-6a1e-5f33-94553ec5302a@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <220cea35-47f1-6a1e-5f33-94553ec5302a@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify
 logging level as a string
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Tue, Jun 02, 2020 at 11:05:57AM +0300, Oleg Babin wrote:
> Also. I've found that it's not allowed to set log level as string via box
> API:
> 
> ```
> 
> tarantool> box.cfg{log_level = 'info'}
> ---
> - error: 'Incorrect value for option ''log_level'': should be of type
> number'
> ...
> 
> ```
> 
> But it could be easily fixed here: https://github.com/tarantool/tarantool/blob/master/src/box/lua/load_cfg.lua#L129

Yeah, I left it on intent. Didn't want to change box.cfg api.
Currently the keywords are parsed in log module solely so I'll
have to provide some way to make similar inside load_cfg code,
and I tried to escape it.

You know, the base idea is to configure logging via log module
solely and maybe deprecate it from box.cfg.

Anyway even if I fix it I'll do it on top of the series.