From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E7D34469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 20:29:24 +0300 (MSK)
Date: Mon, 1 Jun 2020 20:29:04 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200601172904.epficmoznfmifubz@tkn_work_nb>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <5bd340ed-f75f-42b5-d0e3-2b6870285add@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5bd340ed-f75f-42b5-d0e3-2b6870285add@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 00/25] Add static analysis with
 luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

On Mon, Jun 01, 2020 at 07:08:09PM +0200, Vladislav Shpilevoy wrote:
> Hi!
> 
> Sorry, looks like this version also is not the final. Alexander T.
> joined the review, and Igor still has comments. So I am going to
> skip this one, and review the next version.

I just noted my objections against enabling redefinition warning by
default. I asked this two times in March, but it was in a chat and it
seems it was missed.

Also noted objection against removing unused arguments, when they show a
function contract.

Nothing more. It is not full review and I hope I will not asked to do
it.

WBR, Alexander Turenko.