From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9E22469710 for ; Mon, 1 Jun 2020 17:10:23 +0300 (MSK) Date: Mon, 1 Jun 2020 17:10:05 +0300 From: Alexander Turenko Message-ID: <20200601141005.wuatb3vskk7wtfys@tkn_work_nb> References: <50e54317a46f453af5ae834e507a3b8fbc02be06.1590764167.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50e54317a46f453af5ae834e507a3b8fbc02be06.1590764167.git.sergeyb@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v6 04/25] Fix luacheck warnings in extra/dist/tarantoolctl.in List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org > local function rocks() > local cfg = require("luarocks.core.cfg") > cfg.init() > local util = require("luarocks.util") > local command_line = require("luarocks.cmd") > -- Tweak help messages > - util.see_help = function(command, program) > + util.see_help = function() > -- TODO: print extended help message here > return "See Tarantool documentation for help." > end Those argument names looks useful: one don't need to find the original function from luarocks to understand that the message may be different for each command. Those arguments hold the function contract and so informative. I would ignore luacheck warning rather then remove the arguments. luacheck should not push us to make the code less informative. NB: When add inline ignore rules for luacheck I prefer to use a text name of a warning rather than its number (or just '-- luacheck: ignore'): it is more readable. This partcular case would be '-- luacheck: no unused args'. WBR, Alexander Turenko.