From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 87491469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 16:37:33 +0300 (MSK)
Date: Mon, 1 Jun 2020 16:37:15 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200601133715.px7reef7xmhrdbfx@tkn_work_nb>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <2fe2a41b8028623b6e5d72c59be716b81dce1e37.1590764167.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2fe2a41b8028623b6e5d72c59be716b81dce1e37.1590764167.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 08/25] Fix luacheck warnings in
	test/app-tap
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

> -local function execute_and_verify(test, client, input, exp_output, name)
> -    test:test(name, function(test)
> +local function execute_and_verify(testcase, client, input, exp_output, name)
> +    testcase:test(name, function(test)

Please, don't forbid redefinitions. I often use it for 'standard' names
like 'opts', 'ok', 'err', 'test'. It allows to write code blocks in the
same style:

 | local ok, err = <...>
 | <...>
 | local ok, err = <...>

Instead of lopsided way (which also give additional problems, when you
change such code):

 | local ok, err = <...>
 | <...>
 | ok, err = <..>

Or with artificial declarations at block start:

 | local ok, err
 | <...>
 | ok, err = <...>
 | <...>
 | ok, err = <...>

I don't like the requirement to use 'testcase', 'testcasecase' or
'test2', 'test3' to name usual 'test' variable.

WBR, Alexander Turenko.