From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9E6D1469710 for ; Mon, 1 Jun 2020 15:40:08 +0300 (MSK) Date: Mon, 1 Jun 2020 15:39:50 +0300 From: Alexander Turenko Message-ID: <20200601123950.fj2c3tjza7hbksf6@tkn_work_nb> References: <863e5ca812384f62cc573f96b1b314fe87a0b86d.1589999586.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <863e5ca812384f62cc573f96b1b314fe87a0b86d.1589999586.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] Set full testing for all branches List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org On Wed, May 20, 2020 at 09:35:31PM +0300, Alexander V. Tikhonov wrote: > Set full testing with deploy builds and tests for all branches. > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/all-tests-in-branches > > .gitlab-ci.yml | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 256b368c4..55b006ed4 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -8,11 +8,6 @@ variables: > > # Jobs templates > > -.release_only_template: &release_only_definition > - only: > - - master > - - /^.*-full-ci$/ > - > .deploy_only_template: &deploy_only_definition > only: > - master > except: > - schedules > - external_pull_requests > - merge_requests > > .pack_only_template: &pack_only_definition > only: > - schedules > - external_pull_requests > - merge_requests > - - /^.*-full-ci$/ > + - branches > + - tags First, there is not reason to list 'schedules', 'external_pull_requests' and so if you want to just run it everywhere. Second, we should not run both 'just packaging' and 'packaging and deployment' jobs on master. I would make ''pack_only_template' be just 'except: master'. Yep, it is not perfect: 'schedules', 'external_pull_requests' will don't run neither 'pack', nor 'deploy'. But this change is simple and downsides are acceptable. By the way, I don't know anything about pipeline for tagged commits in GitLab. What jobs will run on a tagged commit? Are we affected by [#3745][4] in context of GitLab CI deployments? Just curious, not part of this task. Just side note: I still believe that things would be simpler if we would deploy within a packaging job: this way we need only condition 'when not to deploy' and don't need its negation. (I proposed this in [1].) Now I see that it would be implemented not just like as it is done in Travis CI, because GitLab CI is weird about separate build and deploy stages (see [2], [3]), but would be implemented inside one jobs. Anyway, I don't insist, especially within this task. [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/013893.html [2]: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/336 [3]: https://gitlab.com/gitlab-org/gitlab/-/issues/29265 [4]: https://github.com/tarantool/tarantool/issues/3745 WBR, Alexander Turenko.