From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 58840469710 for ; Mon, 1 Jun 2020 13:48:14 +0300 (MSK) Date: Mon, 1 Jun 2020 13:47:56 +0300 From: Alexander Turenko Message-ID: <20200601104756.7kxdl5kmlzn3gonm@tkn_work_nb> References: <3cc793c75b3e5e3ea58c607778aac4fc74ba784a.1590901924.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3cc793c75b3e5e3ea58c607778aac4fc74ba784a.1590901924.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote: > During investigation of the issues found that error message had > not user friendly format: > local pwgr_errstr = "get%s failed [errno %d]: %s" > produced: > [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory > while it had to be: > [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory > Fixed the error message. My bad, looks as regression from 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch from deserialization'). LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file or directory', without leading 'get'. WBR, Alexander Turenko.