From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F0DF2469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 13:37:39 +0300 (MSK)
Date: Mon, 1 Jun 2020 13:36:39 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200601103639.GC37818@pony.bronevichok.ru>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <b10824401496b58ef509ad3fc8b029071f88c8b6.1590764167.git.sergeyb@tarantool.org>
 <20200529165158.GJ21558@tarantool.org>
 <20200529191358.GL21558@tarantool.org>
 <20200530121553.GA69@pony.bronevichok.ru>
 <20200601094300.GO21558@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200601094300.GO21558@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 05/25] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org

On 12:43 Mon 01 Jun , Igor Munkin wrote:
> Sergey,
> 
> The root cause of these warnings is not related to globals per se, but
> to theirs modification. So you need to add suppressions for [122] and
> [142] codes similar to ones you added for extra/dist/tarantoolctl.in.

Done and pushed to remote branch.

> On 30.05.20, Sergey Bronnikov wrote:
> > On 22:13 Fri 29 May , Igor Munkin wrote:
> > > One more comment: if LuaJIT std is set, suppressions for os and package
> > > globals can be omitted.
> > 
> > with suggested changes new warnings appears:
> > 
> > Checking src/lua/init.lua                         4 warnings
> > 
> > src/lua/init.lua:83:1: (W122) setting read-only field exit of global os
> > src/lua/init.lua:225:1: (W142) setting undefined field search of global package
> > src/lua/init.lua:226:1: (W142) setting undefined field searchroot of global package
> > src/lua/init.lua:227:1: (W142) setting undefined field setsearchroot of global package
> > 
> > so I reverted back
> > 
> > > -- 
> > > Best regards,
> > > IM
> 
> -- 
> Best regards,
> IM