From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2BB2B469710 for ; Mon, 1 Jun 2020 12:51:27 +0300 (MSK) Date: Mon, 1 Jun 2020 12:43:00 +0300 From: Igor Munkin Message-ID: <20200601094300.GO21558@tarantool.org> References: <20200529165158.GJ21558@tarantool.org> <20200529191358.GL21558@tarantool.org> <20200530121553.GA69@pony.bronevichok.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200530121553.GA69@pony.bronevichok.ru> Subject: Re: [Tarantool-patches] [PATCH v6 05/25] Fix luacheck warnings in src/lua/ List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Bronnikov Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Sergey, The root cause of these warnings is not related to globals per se, but to theirs modification. So you need to add suppressions for [122] and [142] codes similar to ones you added for extra/dist/tarantoolctl.in. On 30.05.20, Sergey Bronnikov wrote: > On 22:13 Fri 29 May , Igor Munkin wrote: > > One more comment: if LuaJIT std is set, suppressions for os and package > > globals can be omitted. > > with suggested changes new warnings appears: > > Checking src/lua/init.lua 4 warnings > > src/lua/init.lua:83:1: (W122) setting read-only field exit of global os > src/lua/init.lua:225:1: (W142) setting undefined field search of global package > src/lua/init.lua:226:1: (W142) setting undefined field searchroot of global package > src/lua/init.lua:227:1: (W142) setting undefined field setsearchroot of global package > > so I reverted back > > > -- > > Best regards, > > IM -- Best regards, IM