From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 41C3D469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 12:39:53 +0300 (MSK)
Date: Mon, 1 Jun 2020 12:38:52 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200601093852.GB37818@pony.bronevichok.ru>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <b10824401496b58ef509ad3fc8b029071f88c8b6.1590764167.git.sergeyb@tarantool.org>
 <20200529165158.GJ21558@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200529165158.GJ21558@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 05/25] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org

Igor,

thanks for review!

On 19:51 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! It LGTM, except the one comment: I see the
> following suppression rule in the next patch and see no reasons not to
> add it within this one.
> 
> | files["**/*.lua"] = {
> |     globals = {"box", "_TARANTOOL"},
> |     ignore = {"212/self", "143"}
> | }

Updated .luacheckrc in a patch for src/lua.
Changes pushed to a remote branch.

<snipped>