From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 433A9469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 12:30:58 +0300 (MSK)
Date: Mon, 1 Jun 2020 12:29:57 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200601092957.GA37818@pony.bronevichok.ru>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <9f6489ac103fb1148bf754832dc85d9b3e31d7d8.1590764167.git.sergeyb@tarantool.org>
 <20200529192516.GM21558@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200529192516.GM21558@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static
	analysis with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org

Igor,

thanks for review!

On 22:25 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! It LGTM, except the one comment: I'm not a Gitlab
> CI expert but since you introduced a separate make rule for luacheck, it
> looks like you can use it also in CI. As a result of such change we have
> a single place where luacheck command is mentioned excplicitly in our
> project, that simplifies further maintenance.

You are right, it is a piece of duplicated code. But in a CI I don't use
tarantool build infrastructure at all, because we don't need to build
tarantool to check Lua code used in it. Let me know if you have an ideas
how to share luacheck command line with CMakeLists.txt and GitLab CI
config.

> On 29.05.20, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > Part of #4681
> > ---
> >  .gitlab-ci.yml | 11 +++++++++++
> >  .travis.mk     | 17 +++++++++++++++++
> >  2 files changed, 28 insertions(+)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@