From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D7049469710 for ; Mon, 1 Jun 2020 12:24:52 +0300 (MSK) Date: Mon, 1 Jun 2020 12:24:49 +0300 From: "Alexander V. Tikhonov" Message-ID: <20200601092449.GA5590@hpalx> References: <20200402154444.GA8132@pony.bronevichok.ru> <20200515170409.GA10228@hpalx> <20200518100058.GC20053@pony.bronevichok.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518100058.GC20053@pony.bronevichok.ru> Subject: Re: [Tarantool-patches] [PATCH v1] Divide test box/net.box List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Hi Sergey, thanks for the suggestions, I've tried to use Tarantool packages 1.6.8 version and older, but met a lot of issue with it's installing. Also the main issue that it's not possible to rebuild Tarantool of the old packages in the new OS. The only found available package fot Ubuntu:14.04, but it has issues with installation dependencies, anyway it's version is later than checking patches. These issues were reported to out team and decided to avoid of checking patches for fixes older than 1.7-1.9 versions. On Mon, May 18, 2020 at 01:00:58PM +0300, Sergey Bronnikov wrote: > Hi, Alexander > > On 20:04 Fri 15 May , Alexander V. Tikhonov wrote: > > Hi Sergey, thanks a lot for the review. As we discussed the ability to > > reproduce the issues on the fixing commits I've checked group of tests: > > 10 tests as you asked in the issue and 3 that I've already checked. > > Whithin these tests results were: > > 3 tests: all reproduced the issue > > 10 tests: > > 4 - reproduced the issue > > 1 - didn't show the issue > > could you reproduce issue using original test with source code without fix? > > > 5 - couldn't build and test too old fixes committed in 1.6 Tarantool > > version. > > could you reproduce them using tarantool from packages? > > > To see the results with names please check the issue in github, where > > I've created the table of results for the checked tests. > > > > On Thu, Apr 02, 2020 at 06:44:44PM +0300, Sergey Bronnikov wrote: > > > Hello! > > > > > > before splitting test we had a net.box.skipcond file due to an issue > > > https://github.com/tarantool/tarantool/issues/4271. I believe that file > > > is useless now and we should add similar files for a new tests. > > > > > > I have looked on tests without postfix "gh-xxx" in a filenames. > > > LGTM for them: > > > > > > net.box_connect_triggers.test.lua > > > net.box_permissions.test.lua > > > net.box_reconnect_after.test.lua > > > net.box_get_connection_object.test.lua > > > > > > I propose to run tests with postfix "gh-xxx" in filenames on commits > > > before fix where bug covered by test was added. Broken test would mean > > > it still works. > > > > > > Sergey > > > > >