From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 82BCB469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  1 Jun 2020 11:58:45 +0300 (MSK)
Date: Mon, 1 Jun 2020 11:57:45 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200601085745.GB50668@pony.bronevichok.ru>
References: <b3f158c1cfde5a693101a968285aba0cea6c12a1.1590900417.git.avtikhon@tarantool.org>
 <6c05edf113965cdf0c6954476ed3928aa83a1e74.1590900417.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6c05edf113965cdf0c6954476ed3928aa83a1e74.1590900417.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition
	of app-tap/pwd test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

LGTM

On 08:09 Sun 31 May , Alexander V. Tikhonov wrote:
> During creating patch:
> 
>   e3d9d8c97edd39438cbc98fccac996e61ce4984c ("build: add CentOS 8 into CI / CD")
> 
> was found the issue:
> 
>   [001] app-tap/pwd.test.lua                                            [ fail ]
>   [001] Test failed! Output from reject file app-tap/pwd.reject:
>   [001] TAP version 13
>   [001] 1..6
>   [001] ok - checking user by id
>   [001] ok - checking user by name
>   [001] ok - checking group by id
>   [001] ok - checking group by name
>   [001]
>   [001] Last 15 lines of Tarantool Log file [Instance "app_server"][/mnt/test/var/001_app-tap/pwd.test.lua.tarantool.log]:
>   [001] tarantool: /lib64/libcurl.so.4: no version information available (required by tarantool)
>   [001] builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory
> 
> Currently it was tried to reproduce the issue, but all the attempts
> didn't got the needed fail. After discussion of the issue decided to
> close the current one as not the issue for the test and continue the
> fixes for getpwall/getgrall functions within issue #5034.
> 
> Closes #4592
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4592
> 
>  test/app-tap/pwd.skipcond | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 test/app-tap/pwd.skipcond
> 
> diff --git a/test/app-tap/pwd.skipcond b/test/app-tap/pwd.skipcond
> deleted file mode 100644
> index cf97461bc..000000000
> --- a/test/app-tap/pwd.skipcond
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -import subprocess
> -
> -# Disable the test on CentOS 8 until gh-4592 will be resolved.
> -try:
> -    cmd = ['rpm', '--eval', '%{centos_ver}']
> -    if subprocess.check_output(cmd).strip() == '8':
> -        self.skip = 1
> -except:
> -    pass
> -
> -# vim: set ft=python:
> -- 
> 2.17.1
> 

-- 
sergeyb@