From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C11C0469710
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 30 May 2020 15:23:13 +0300 (MSK)
Date: Sat, 30 May 2020 15:22:13 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200530122213.GD69@pony.bronevichok.ru>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <fb74b3e969e4399740768b2da8bf849d7e8f25f6.1590764167.git.sergeyb@tarantool.org>
 <20200529191153.GK21558@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200529191153.GK21558@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 06/25] Fix luacheck warnings in
	src/box/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org

Igor,

thanks for review!

On 22:11 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! It LGTM, except the one comment: if LuaJIT std is
> set, suppressions for bit global can be omitted.

global 'bit' is now omitted

> On 29.05.20, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > Part of #4681
> > 
> > Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > ---
> >  .luacheckrc                     |  9 +++++-
> >  src/box/lua/console.lua         |  6 ++--
> >  src/box/lua/feedback_daemon.lua |  2 +-
> >  src/box/lua/key_def.lua         |  2 +-
> >  src/box/lua/load_cfg.lua        | 31 +++++++++----------
> >  src/box/lua/net_box.lua         | 55 +++++++++++++--------------------
> >  src/box/lua/schema.lua          | 50 +++++++++++++++---------------
> >  src/box/lua/tuple.lua           |  8 ++---
> >  src/box/lua/upgrade.lua         | 19 ++++++------
> >  9 files changed, 87 insertions(+), 95 deletions(-)
> > 
> > diff --git a/.luacheckrc b/.luacheckrc
> > index 4d95f2729..03a51ba3e 100644
> > --- a/.luacheckrc
> > +++ b/.luacheckrc
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@