From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 22F96469710
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 30 May 2020 15:19:58 +0300 (MSK)
Date: Sat, 30 May 2020 15:18:58 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200530121858.GB69@pony.bronevichok.ru>
References: <cover.1590764167.git.sergeyb@tarantool.org>
 <ef745bc499e0cd4df2f19f0f386ca4f6badca0be.1590764167.git.sergeyb@tarantool.org>
 <20200529160429.GF21558@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200529160429.GF21558@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 01/25] Add initial luacheck config
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org

Igor,

thanks for review!

On 19:04 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! Here is my comment from previous series[1]:
> | Several chunks in test/vinyl/ directory are not diff-based tests but
> | either instance configs (e.g. test/vinyl/vinyl.lua) or auxiliary modules
> | (e.g. test/vinyl/large.lua). I guess we need to check at least the
> | latter ones.
> 
> I meant to change file mask for *all* test/ subdirectories in exclude
> list the following way: s/\*.lua$/\*.test.lua/g.

File masks updated and new warnings has been fixed. New changes are in
commits with message headers like "Update file mask...".

> Otherwise, LGTM.
> 
> On 29.05.20, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > config includes all files with Lua source code except:
> > - third_party repositories
> > - directories with diff-based tests
> > 
> > How-to check:
> > 
> > $ tarantoolctl rocks install luacheck
> > $ .rocks/bin/luacheck --codes --config .luacheckrc .
> > 
> > Part of #4681
> > 
> > Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > ---
> >  .luacheckrc | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 .luacheckrc
> > 
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017073.html
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@