From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D7624469710 for ; Fri, 29 May 2020 22:33:41 +0300 (MSK) Date: Fri, 29 May 2020 22:25:16 +0300 From: Igor Munkin Message-ID: <20200529192516.GM21558@tarantool.org> References: <9f6489ac103fb1148bf754832dc85d9b3e31d7d8.1590764167.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9f6489ac103fb1148bf754832dc85d9b3e31d7d8.1590764167.git.sergeyb@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Sergey, Thanks for the patch! It LGTM, except the one comment: I'm not a Gitlab CI expert but since you introduced a separate make rule for luacheck, it looks like you can use it also in CI. As a result of such change we have a single place where luacheck command is mentioned excplicitly in our project, that simplifies further maintenance. On 29.05.20, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > Part of #4681 > --- > .gitlab-ci.yml | 11 +++++++++++ > .travis.mk | 17 +++++++++++++++++ > 2 files changed, 28 insertions(+) > > -- > 2.23.0 > -- Best regards, IM