From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DB7C9469710 for ; Fri, 29 May 2020 19:12:55 +0300 (MSK) Date: Fri, 29 May 2020 19:04:29 +0300 From: Igor Munkin Message-ID: <20200529160429.GF21558@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v6 01/25] Add initial luacheck config List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Sergey, Thanks for the patch! Here is my comment from previous series[1]: | Several chunks in test/vinyl/ directory are not diff-based tests but | either instance configs (e.g. test/vinyl/vinyl.lua) or auxiliary modules | (e.g. test/vinyl/large.lua). I guess we need to check at least the | latter ones. I meant to change file mask for *all* test/ subdirectories in exclude list the following way: s/\*.lua$/\*.test.lua/g. Otherwise, LGTM. On 29.05.20, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > config includes all files with Lua source code except: > - third_party repositories > - directories with diff-based tests > > How-to check: > > $ tarantoolctl rocks install luacheck > $ .rocks/bin/luacheck --codes --config .luacheckrc . > > Part of #4681 > > Reviewed-by: Vladislav Shpilevoy > Co-authored-by: Vladislav Shpilevoy > --- > .luacheckrc | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 .luacheckrc > > -- > 2.23.0 > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017073.html -- Best regards, IM