From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AE671469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 15:07:06 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id x27so1147757lfg.9
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 05:07:06 -0700 (PDT)
Date: Fri, 29 May 2020 15:07:03 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200529120703.GM215590@grain>
References: <cover.1590403792.git.sergepetrenko@tarantool.org>
 <d414d4c52942658c9b36581e9f1e12956a9270e8.1590403792.git.sergepetrenko@tarantool.org>
 <d5c68931-269f-c68e-851e-5076c52e2f29@tarantool.org>
 <266e9768-27ea-e924-e562-846e74df7760@tarantool.org>
 <20200529115154.GA144179@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20200529115154.GA144179@atlas>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that
 a tx ends on a global row
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, May 29, 2020 at 02:51:54PM +0300, Konstantin Osipov wrote:
> * Serge Petrenko <sergepetrenko@tarantool.org> [20/05/29 14:44]:
> > I understand this is a crutch, but it's the best solution I could come
> > up with.=A0 Appending dummy=A0 NOPs will increase instance LSN by one,
> > which=A0 also looks=A0 ugly. The correct solution is, indeed, to collec=
t=A0 a tx
> > in relay and mangle with it in any means=A0 we need before sending, how=
ever,
> > I faced some problems with this approach. See more in v1 of this patchs=
et
> > (letter [PATCH 2/2] replication: make relay send txs in batches).
> >=20
>=20
> What were the issues changing xstream api apart from never trying?

Just for info -- I've filed a bug for this, didn't find time to look
deeper though.