From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 13DE2469710 for ; Fri, 29 May 2020 14:51:57 +0300 (MSK) Received: by mail-lj1-f174.google.com with SMTP id b6so2272001ljj.1 for ; Fri, 29 May 2020 04:51:56 -0700 (PDT) Date: Fri, 29 May 2020 14:51:54 +0300 From: Konstantin Osipov Message-ID: <20200529115154.GA144179@atlas> References: <266e9768-27ea-e924-e562-846e74df7760@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <266e9768-27ea-e924-e562-846e74df7760@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Serge Petrenko [20/05/29 14:44]: > I understand this is a crutch, but it's the best solution I could come > up with.  Appending dummy  NOPs will increase instance LSN by one, > which  also looks  ugly. The correct solution is, indeed, to collect  a tx > in relay and mangle with it in any means  we need before sending, however, > I faced some problems with this approach. See more in v1 of this patchset > (letter [PATCH 2/2] replication: make relay send txs in batches). > What were the issues changing xstream api apart from never trying? -- Konstantin Osipov, Moscow, Russia https://scylladb.com