From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5BB05469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 14:29:06 +0300 (MSK)
Date: Fri, 29 May 2020 14:20:40 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200529112040.GE21558@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <76c48726826d42c167e89c3c032cb972e6ea9f32.1589275364.git.sergeyb@tarantool.org>
 <20200526221510.GR5455@tarantool.org>
 <20200528153134.GB50538@pony.bronevichok.ru>
 <20200528160754.GC50538@pony.bronevichok.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200528160754.GC50538@pony.bronevichok.ru>
Subject: Re: [Tarantool-patches] [PATCH v5 01/10] Add initial luacheck config
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Sergey,

On 28.05.20, Sergey Bronnikov wrote:
> On 18:31 Thu 28 May , Sergey Bronnikov wrote:
> 
> <snipped>
> 
> > > > +    "build/**/*.lua",
> > > > +    "src/box/lua/serpent.lua", -- third-party source code
> > > > +    "test/app/*.lua",
> > > > +    "test/app-tap/lua/serializer_test.lua",
> > > 
> > > Why did you exclude the file above?
> > 
> > Actually I don't remember a reason, right now it is useless,
> > so removed it from a list.
> 
> the reason is:
> "test/app-tap/lua/serializer_test.lua:261:18: (E011) expected expression near 'М'"
> and I don't know how to fix it. So added exclusion back.

OK, it looks like luacheck doesn't allow non-ascii symbols in unquoted
strings. After applying the following patch luacheck reports only
warnings.

================================================================================

diff --git a/test/app-tap/lua/serializer_test.lua b/test/app-tap/lua/serializer_test.lua
index 2a668f898..8aabc2617 100644
--- a/test/app-tap/lua/serializer_test.lua
+++ b/test/app-tap/lua/serializer_test.lua
@@ -258,7 +258,7 @@ local function test_table(test, s, is_array, is_map)
     test:ok(is_map(s.encode({k1 = 'v1', k2 = 'v2', k3 = 'v3'})), "map is map")
 
     -- utf-8 pairs
-    rt(test, s, {Метапеременная = { 'Метазначение' }})
+    rt(test, s, {['Mетапеременная'] = { 'Метазначение' }})
     rt(test, s, {test = { 'Результат' }})
 
     local arr = setmetatable({1, 2, 3, k1 = 'v1', k2 = 'v2', 4, 5},

================================================================================

I guess you can file an issue to luacheck repo queue regarding this
issue.

> 
> <snipped>

-- 
Best regards,
IM