From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8B93B469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 11:54:21 +0300 (MSK)
Date: Fri, 29 May 2020 11:53:24 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200529085324.GA74017@pony.bronevichok.ru>
References: <cover.1590622225.git.v.shpilevoy@tarantool.org>
 <645228196cb289f4bbf8e1df47f17ea958cd9237.1590622225.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <645228196cb289f4bbf8e1df47f17ea958cd9237.1590622225.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 03/10] cmake: add option
 ENABLE_UB_SANITIZER
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Vlad,

thanks for the patch!

On 01:32 Thu 28 May , Vladislav Shpilevoy wrote:

<snipped>

> diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake
> index ce3e7e506..373bcd3b0 100644
> --- a/cmake/compiler.cmake
> +++ b/cmake/compiler.cmake
> @@ -238,6 +238,8 @@ endif()
>  
>  option(ENABLE_WERROR "Make all compiler warnings into errors" OFF)
>  
> +option(ENABLE_UB_SANITIZER "Make the compiler generate runtime code to perform undefined behaviour checks" OFF)

It would be useful to add ENABLE_UB_SANITIZER option to a list "options"
in a root CMakeLists.txt. cmake shows options from this list and it's
status at the end of output.

<snipped>