From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7AB6B469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 09:24:47 +0300 (MSK)
Date: Fri, 29 May 2020 09:24:45 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200529062445.5vs7tgq4yceu4hie@tarantool.org>
References: <cover.1590622225.git.v.shpilevoy@tarantool.org>
 <de14e939dcfeadde645197e34ffb185c5f36177b.1590622225.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de14e939dcfeadde645197e34ffb185c5f36177b.1590622225.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 02/10] cmake: ignore warnings on
 alignof() and offsetof()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 28 май 01:32, Vladislav Shpilevoy wrote:
> --- a/cmake/compiler.cmake
> +++ b/cmake/compiler.cmake
> @@ -276,11 +276,12 @@ macro(enable_tnt_compile_flags)
>          add_compile_flags("C;CXX" "-Wno-format-truncation")
>      endif()
>  
> -    if (CMAKE_COMPILER_IS_GNUCXX)
> +    if (CMAKE_COMPILER_IS_CLANG OR CMAKE_COMPILER_IS_GNUCXX)
>          # G++ bug. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31488
>          add_compile_flags("CXX"
>              "-Wno-invalid-offsetof"
>          )

So, you're disabling the warning for clang? According to comment it
was disabled for GCC because of bug in it. Update comment? Enable for
clang?

--
Regards, Kirill Yukhin