From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3A6C9469710 for ; Thu, 28 May 2020 14:16:45 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id x27so16325023lfg.9 for ; Thu, 28 May 2020 04:16:44 -0700 (PDT) Date: Thu, 28 May 2020 14:16:40 +0300 From: Cyrill Gorcunov Message-ID: <20200528111640.GE215590@grain> References: <20200528100738.221911-1-gorcunov@gmail.com> <20200528100738.221911-3-gorcunov@gmail.com> <24738c25-4cd2-4bb5-66c1-0d957310e97a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24738c25-4cd2-4bb5-66c1-0d957310e97a@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 2/8] lua/log: declare say_logger_init and say_logger_initialized List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lvasiliev Cc: tml On Thu, May 28, 2020 at 02:12:26PM +0300, lvasiliev wrote: > Hi! Thank you for the patch. > LGTM, except a comment below. > > On 28.05.2020 13:07, Cyrill Gorcunov wrote: > > We gonna use it to provide a way to initialize > > logger subsystem early. > > > > Part-of #689 > > > > Signed-off-by: Cyrill Gorcunov > > --- > > src/lua/log.lua | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/lua/log.lua b/src/lua/log.lua > > index 312c14d5e..9830b0886 100644 > > --- a/src/lua/log.lua > > +++ b/src/lua/log.lua > > @@ -1,5 +1,7 @@ > > -- log.lua > > -- > > +-- vim: ts=4 sw=4 et > > Elders must decide whether or not to use vim ... I'll drop it (since it put pants in fire fore some people ;)