From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EA3FB469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:50:18 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id z6so32746318ljm.13
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 03:50:18 -0700 (PDT)
Date: Thu, 28 May 2020 13:50:16 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200528105016.GD215590@grain>
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-9-gorcunov@gmail.com>
 <e85857e8-2a35-6b86-bb60-af1da59dbfee@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e85857e8-2a35-6b86-bb60-af1da59dbfee@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 8/8] test: use direct log module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, May 28, 2020 at 01:42:32PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch. See several comments below.
> 
> On 28/05/2020 13:07, Cyrill Gorcunov wrote:
> > To test if we can setup logging module before the box/cfg{}.
> 
> nit: `box.cfg{}`, not `box/cfg{}`

Thanks!

> > +--
> > +-- gh-689: Operate with logger via log module without calling box.cfg{}
> 
> As we've discussed it's better to add "negative" cases to tests.
> There are examples, e.g. https://github.com/tarantool/tarantool/blob/master/test/app-tap/yaml.test.lua#L86

Yes, thanks a huge!