From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85BF1469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:49:46 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id z6so32744592ljm.13
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 03:49:46 -0700 (PDT)
Date: Thu, 28 May 2020 13:49:44 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200528104944.GC215590@grain>
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-7-gorcunov@gmail.com>
 <75bcf79f-3589-efba-6ac7-ef3585179a15@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <75bcf79f-3589-efba-6ac7-ef3585179a15@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 6/8] lua/log: use log module
	settings inside box.cfg
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, May 28, 2020 at 01:41:54PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch! Looks good but I still think that log prefixes
> are redundant. Is it possible to drop them?
> 
> E.g. yaml.cfg example (no "yaml_" prefixes):
> ```
> tarantool> require('yaml').cfg
> ---
> - encode_load_metatables: true
>   encode_invalid_numbers: true
>   encode_use_tostring: false
>   decode_max_depth: 128
>   encode_number_precision: 14
>   encode_sparse_convert: true
>   encode_max_depth: 128
>   decode_invalid_numbers: true
>   encode_sparse_ratio: 2
>   encode_invalid_as_nil: false
>   encode_sparse_safe: 10
>   encode_deep_as_nil: false
>   decode_save_metatables: true
> ...
> ```
> 
> ```
> tarantool> require('log').cfg
> ---
> - log_format: json
>   log_level: 1000
>   log_nonblock: false
> ...
> ```

Somehow managed to miss this comment in on of yours
previous replies, sorry. I'll take a look.