From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CB283469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:48:40 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id e125so16307252lfd.1
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 03:48:40 -0700 (PDT)
Date: Thu, 28 May 2020 13:48:38 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200528104838.GB215590@grain>
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-5-gorcunov@gmail.com>
 <f69e9e6c-f210-f0af-d0e1-a1e486ba76d6@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f69e9e6c-f210-f0af-d0e1-a1e486ba76d6@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 4/8] lua/log: do not allow to set
	json for boot logger
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, May 28, 2020 at 01:40:25PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch see one comment below.
> 
> > diff --git a/test/app-tap/logger.test.lua b/test/app-tap/logger.test.lua
> > index 492d5ea0b..7bfa06e80 100755
> > --- a/test/app-tap/logger.test.lua
> > +++ b/test/app-tap/logger.test.lua
> > @@ -5,7 +5,6 @@ test:plan(24)
> >   -- gh-3946: Assertion failure when using log_format() before box.cfg()
> >   local log = require('log')
> > -log.log_format('json')
> 
> I think you can change it to "pcall(log.log_format, 'json')" and check that
> it returns an error. Not simply drop a test case.

Good catch! Thanks, will update!