From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8B25F469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:47:57 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id c21so16304814lfb.3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 03:47:57 -0700 (PDT)
Date: Thu, 28 May 2020 13:47:54 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200528104754.GA215590@grain>
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-2-gorcunov@gmail.com>
 <50a32f08-7cb0-bfe0-c63f-da91d6e7331b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50a32f08-7cb0-bfe0-c63f-da91d6e7331b@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig
 early set up logger
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: lvasiliev <lvasiliev@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, May 28, 2020 at 01:42:01PM +0300, lvasiliev wrote:
> Hi! Thank you for the patch.
> I have a minor comment that can be skipped silently.
> 
> > diff --git a/src/lib/core/say.h b/src/lib/core/say.h
> > index c50d7bbf4..857145465 100644
> > --- a/src/lib/core/say.h
> > +++ b/src/lib/core/say.h
> > @@ -274,6 +274,10 @@ say_logger_init(const char *init_str,
> >   		const char *log_format,
> >   		int background);
> > +/** Test if logger is initialized. */
> > +bool
> > +say_logger_initialized(void);
> > +
> 
> I think this function may be used for the check in say_logger_free()
> instead log_default == &log_std.

True, I'll update. Thanks!