From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B3040469710 for ; Thu, 28 May 2020 10:24:20 +0300 (MSK) Date: Thu, 28 May 2020 10:24:19 +0300 From: Kirill Yukhin Message-ID: <20200528072419.ruhexorkw76shs34@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] fk: fix wrong sizeof() in fk_constraint_def_sizeof() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 28 май 01:25, Vladislav Shpilevoy wrote: > The function returns a number of bytes needed to store > an fk_constraint_def object with its name and links. > However it used sizeof(struct fk_constraint) instead > of sizeof(struct fk_constraint_def) to calculate > base object size. This worked only because > fk_constraint is bigger than fk_constraint_def. > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/fk_constraint_sizeof Checked into 2.3, 2.4 and master as obvious. -- Regards, Kirill Yukhin