From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 78899469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 May 2020 14:30:30 +0300 (MSK)
Date: Wed, 27 May 2020 14:22:04 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200527112204.GU5455@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <1a49a09206b23b0fa9367381e1ae7d08d6bf11b3.1589275364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1a49a09206b23b0fa9367381e1ae7d08d6bf11b3.1589275364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 04/10] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, alexander.turenko@tarantool.org

Sergey,

Thanks for the patch! I propose to add suppressions also for the
remaining globals such as os, package in init.lua and help, tutorial in
help.lua to fix all warnings reported for src/lua directory in scope of
this patch.

Otherwise LGTM, as for the major patch.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
>  .luacheckrc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index f39502063..3cd05a254 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -29,3 +29,6 @@ files["extra/dist/tarantoolctl.in"] = {
>  	globals = {"box", "_TARANTOOL"},
>  	ignore = {"212/self", "122", "431"}
>  }
> +files["src/lua/*.lua"] = {ignore = {"212/self"}}
> +files["src/lua/init.lua"] = {globals = {"dostring"}}
> +files["src/lua/swim.lua"] = {ignore = {"431"}}
> -- 
> 2.23.0
> 

-- 
Best regards,
IM