From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3825E469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 May 2020 02:20:12 +0300 (MSK)
Date: Wed, 27 May 2020 02:11:46 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200526231146.GT5455@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <bd4dad3bf3b9a1266808a32b0a23995eac273e62.1589275364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bd4dad3bf3b9a1266808a32b0a23995eac273e62.1589275364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 03/10] Fix luacheck warnings in
 extra/dist/tarantoolctl.in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, alexander.turenko@tarantool.org

Sergey,

Thanks for the patch! I see there are several changes since v4, so I
re-checked these changeset one more time. Please consider a single nit
below. Otherwise, LGTM.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
>  .luacheckrc                |  5 +++++
>  extra/dist/tarantoolctl.in | 33 +++++++++++----------------------
>  2 files changed, 16 insertions(+), 22 deletions(-)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index 2683c8c26..f39502063 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -24,3 +24,8 @@ exclude_files = {
>      ".rocks/**/*.lua",
>      ".git/**/*.lua",
>  }
> +
> +files["extra/dist/tarantoolctl.in"] = {                                                                                      
> +	globals = {"box", "_TARANTOOL"},                                                                                 
> +	ignore = {"212/self", "122", "431"}                                                                            
> +}

Typo: there is a little mess with whitespace above:
* tabs are used instead of spaces for indentation
* trailing whitespace (but I don't see it on branch)

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM