From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CDA4F469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 May 2020 01:23:35 +0300 (MSK)
Date: Wed, 27 May 2020 01:15:10 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200526221510.GR5455@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <76c48726826d42c167e89c3c032cb972e6ea9f32.1589275364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <76c48726826d42c167e89c3c032cb972e6ea9f32.1589275364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 01/10] Add initial luacheck config
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Sergey,

Thanks for the patch! Please consider several comments I left below.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> config includes all files with Lua source code except:
> - third_party repositories
> - directories with diff-based tests
> 
> How-to check:
> 
> $ tarantoolctl rocks install luacheck
> $ .rocks/bin/luacheck --codes --config .luacheckrc .
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> ---
>  .luacheckrc | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 .luacheckrc
> 
> diff --git a/.luacheckrc b/.luacheckrc
> new file mode 100644
> index 000000000..2683c8c26
> --- /dev/null
> +++ b/.luacheckrc
> @@ -0,0 +1,26 @@
> +include_files = {
> +    "**/*.lua",
> +    "extra/dist/tarantoolctl.in",
> +}
> +
> +exclude_files = {

Minor: IMHO, it is worth to be sorted for better maintenance.

> +    "build/**/*.lua",
> +    "src/box/lua/serpent.lua", -- third-party source code
> +    "test/app/*.lua",
> +    "test/app-tap/lua/serializer_test.lua",

Why did you exclude the file above?

> +    "test/box/**/*.lua",
> +    "test/engine/*.lua",
> +    "test/engine_long/*.lua",
> +    "test/long_run-py/**/*.lua",
> +    "test/vinyl/*.lua",

Several chunks in test/vinyl/ directory are not diff-based tests but
either instance configs (e.g. test/vinyl/vinyl.lua) or auxiliary modules
(e.g. test/vinyl/large.lua). I guess we need to check at least the
latter ones.

> +    "test/replication/*.lua",
> +    "test/sql/*.lua",
> +    "test/swim/*.lua",
> +    "test/xlog/*.lua",
> +    "test/wal_off/*.lua",
> +    "test/var/**/*.lua",
> +    "test-run/**/*.lua",
> +    "third_party/**/*.lua",
> +    ".rocks/**/*.lua",
> +    ".git/**/*.lua",
> +}
> -- 
> 2.23.0
> 

-- 
Best regards,
IM