From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB6B6469710 for ; Tue, 26 May 2020 23:54:02 +0300 (MSK) Date: Tue, 26 May 2020 23:45:37 +0300 From: Igor Munkin Message-ID: <20200526204537.GQ5455@tarantool.org> References: <841b55f0c4f8d53bbb6592f142a60eba4c364393.1589275365.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <841b55f0c4f8d53bbb6592f142a60eba4c364393.1589275365.git.sergeyb@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5 09/10] Add luacheck supressions for luajit tests List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org Sergey, Thanks for the patch! Since you've already fixed the warning <231> in test/luajit-tap/gh-4476-fix-string-find-recording.test.lua here[1], the corresponding suppression below can be removed. Furthermore, please bump LuaJIT submodule in scope of this patch, to pull the corresponding changes made in tarantool/luajit repo. Otherwise, the patch LGTM, thanks! On 12.05.20, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > Closes #4681 > > Reviewed-by: Igor Munkin > --- > .luacheckrc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.luacheckrc b/.luacheckrc > index 26986ffb1..62a0135d1 100644 > --- a/.luacheckrc > +++ b/.luacheckrc > @@ -67,6 +67,8 @@ files["test/box/lua/fifo.lua"] = {globals = {"fifomax", "find_or_create_fifo", " > files["test/box/lua/identifier.lua"] = {globals = {"run_test"}} > files["test/box/lua/require_mod.lua"] = {globals = {"exports"}} > files["test/engine/conflict.lua"] = {globals = {"test_conflict"}} > +files["test/luajit-tap/gh-4476-fix-string-find-recording.test.lua"] = {ignore = {"231"}} > +files["test/luajit-tap/or-232-unsink-64-kptr.test.lua"] = {ignore = {"542"}} > files["test/replication/replica_quorum.lua"] = {globals = {"INSTANCE_URI", "nonexistent_uri"}} > files["test/replication/replica_on_schema_init.lua"] = {globals = {"trig_local", "trig_engine"}} > files["test/replication/lua/fast_replica.lua"] = { > -- > 2.23.0 > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017066.html -- Best regards, IM