From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BD5F8469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 May 2020 19:09:02 +0300 (MSK)
Date: Tue, 26 May 2020 19:00:38 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200526160037.GO5455@tarantool.org>
References: <20200429122038.53296-1-arkholga@tarantool.org>
 <20200525130329.GI5455@tarantool.org>
 <76366f3a-19e4-f039-b84e-670e065d74a0@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <76366f3a-19e4-f039-b84e-670e065d74a0@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance
 in postinstall
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Olya,

Thanks, but I have last (but not least) nit: a ChangeLog entry need to
be plased aside from the commit message, i.e. under three dashes or in a
cover letter. Please adjust your commit message regarding this remark.

On 25.05.20, Olga Arkhangelskaia wrote:
> Hi Igor!
> 
> Have fixed commit message:
> 
>   After tarantool installation on Debian/Ubuntu from repo, example instance
>   was automatically started on 3301 port. At the same time example instance
>   on RHEL/CentOS is started manually. Patch does the same for 
> Debian/Ubuntu.
> 
>    Closes #4507
> 
>    @TarantoolBot document
>    Title: manage example instance after installation
>    After tarantool installation from repos on all distros example instance
>    should be managed manually.
> 
>   @ChangeLog:
>    * Do not start example instance on 3301 port after tarantool 
> installation
>    from Debian/Ubuntu repo.
> 

<snipped>

-- 
Best regards,
IM