From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com
 [209.85.167.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 56D3A469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 May 2020 17:00:39 +0300 (MSK)
Received: by mail-lf1-f42.google.com with SMTP id 202so12372584lfe.5
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 May 2020 07:00:39 -0700 (PDT)
Date: Tue, 26 May 2020 17:00:36 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200526140036.GH2464@grain>
References: <20200526124627.82843-1-gorcunov@gmail.com>
 <f56f697b-6bb9-6ab6-222a-10ecd97fcc77@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f56f697b-6bb9-6ab6-222a-10ecd97fcc77@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 00/10] lua/log: add an ability to
 setup logger without box.cfg{}
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>

On Tue, May 26, 2020 at 04:42:52PM +0300, Oleg Babin wrote:
> Hi! Thanks for your changes.
> 
> I have several comments:
...
> 
> And seems I've missed this issue
> (https://github.com/tarantool/tarantool/issues/1054) when I asked about
> log.cfg. I think you could add "Closes #1054" as well.

Thanks! Will address in next series!