From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A08F9469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 25 May 2020 21:38:38 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id w15so10928961lfe.11
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 25 May 2020 11:38:38 -0700 (PDT)
Date: Mon, 25 May 2020 21:38:33 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200525183833.GG2464@grain>
References: <cover.1589968157.git.kyukhin@tarantool.org>
 <0f65635ef9ee95131ac0e83b0b70e8c204a322b8.1589968157.git.kyukhin@tarantool.org>
 <20200523183032.GB2714@atlas>
 <20200525131354.junz5joymznc6r6j@tarantool.org>
 <20200525143419.GA33892@atlas> <20200525151848.GC2464@grain>
 <20200525164501.GE4272@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200525164501.GE4272@atlas>
Subject: Re: [Tarantool-patches] [PATCH 1/2] Copy DSO module before load
 instead of symlink-ing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, Kirill Yukhin <kyukhin@tarantool.org>, tarantool-patches@dev.tarantool.org

On Mon, May 25, 2020 at 07:45:01PM +0300, Konstantin Osipov wrote:
> > > I don't know why coio_copyfile uses it BTW. Why is eio_sendfile()
> > > not enough?
> > 
> > ```
> > eio_ssize_t
> > eio_sendfile_sync (int ofd, int ifd, off_t offset, size_t count)
> > {
> >   return eio__sendfile (ofd, ifd, offset, count);
> > }
> > ```
> > 
> > They are simply alias to each other.
> 
> Right, but one is public api and the other is not?
> 
> Check eio.pod please.

Indeed :( Thanks! That said I think we simply need to use
eio_sendfile_sync directly, without yields and without
using any for(;;) cycles, the eio will do all inside.