From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 95E37469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 25 May 2020 19:45:03 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id q2so21364403ljm.10
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 25 May 2020 09:45:03 -0700 (PDT)
Date: Mon, 25 May 2020 19:45:01 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200525164501.GE4272@atlas>
References: <cover.1589968157.git.kyukhin@tarantool.org>
 <0f65635ef9ee95131ac0e83b0b70e8c204a322b8.1589968157.git.kyukhin@tarantool.org>
 <20200523183032.GB2714@atlas>
 <20200525131354.junz5joymznc6r6j@tarantool.org>
 <20200525143419.GA33892@atlas> <20200525151848.GC2464@grain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200525151848.GC2464@grain>
Subject: Re: [Tarantool-patches] [PATCH 1/2] Copy DSO module before load
 instead of symlink-ing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

* Cyrill Gorcunov <gorcunov@gmail.com> [20/05/25 18:23]:

> On Mon, May 25, 2020 at 05:34:19PM +0300, Konstantin Osipov wrote:
> > 
> > > +	off_t pos, left;
> > > +	for (left = st.st_size, pos = 0; left > 0;) {
> > > +		off_t ret = eio_sendfile_sync(dest_fd, source_fd, pos,
> > > +					      st.st_size);
> > 
> > I wonder why do you use eio_sendfile_sync()?
> > 
> > I don't know why coio_copyfile uses it BTW. Why is eio_sendfile()
> > not enough?
> 
> ```
> eio_ssize_t
> eio_sendfile_sync (int ofd, int ifd, off_t offset, size_t count)
> {
>   return eio__sendfile (ofd, ifd, offset, count);
> }
> ```
> 
> They are simply alias to each other.

Right, but one is public api and the other is not?

Check eio.pod please.

-- 
Konstantin Osipov, Moscow, Russia