From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BC97A469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 22 May 2020 01:25:44 +0300 (MSK)
Date: Fri, 22 May 2020 01:25:00 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200521222500.GA57997@pony.bronevichok.ru>
References: <cover.1590093222.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1590093222.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/10] Sanitize unaligned access
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Vladislav,

On 22:37 Thu 21 May , Vladislav Shpilevoy wrote:
> The patchset introduces a new cmake option ENABLE_UB_SANITIZER, to
> enable clang undefined behaviour sanitizer.

Intruduced option is disabled by default.
Do you plan to enable it on CI runs?

> The sanitizer revealed lots of unaligned memory accesses, and the
> patchset fixed all of them (which were found).
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4609-sanitize-alignment
> Issue: https://github.com/tarantool/tarantool/issues/4609
> 
> Vladislav Shpilevoy (10):
>   small: sanitized rlist and new region API
>   cmake: ignore warnings on alignof() and offsetof()
>   cmake: add option ENABLE_UB_SANITIZER
>   crc32: disable align sanitizer
>   sql: make BtCursor's memory aligned
>   region: use aligned allocations where necessary
>   vinyl: align statements and bps tree extents
>   tuple: use unaligned store-load for field map
>   port: make port_c_entry not PACKED
>   xrow: use unaligned store operation in xrow_to_iovec()

<snipped>