From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 190D2469710 for ; Thu, 21 May 2020 11:36:03 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id z22so4029078lfd.0 for ; Thu, 21 May 2020 01:36:02 -0700 (PDT) Date: Thu, 21 May 2020 11:36:01 +0300 From: Konstantin Osipov Message-ID: <20200521083601.GA42063@atlas> References: <670c3876e58a7cfa14d45db1dc074a10dd034759.1586808463.git.korablev@tarantool.org> <20200413221229.GA3462@atlas> <20200514021155.GB18509@tarantool.org> <20200514065608.GA12581@atlas> <20200519191006.GB13813@tarantool.org> <20200519193948.GA12955@atlas> <20200521025153.GC19031@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521025153.GC19031@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/2] vinyl: skip invalid upserts during squash List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [20/05/21 05:54]: > Data will always will be acceptable according to the format because > PK format can't change. The format used for squashing may be taken from the primary key lsm, but there are type constraints which impact even non-indexed fields. Imagine nullable -> not null change in SQL, and a pending upsert which assigns NULL to a not nullable field. Or addition/removal of is_optional on a field in the format. We don't allow much there, but it would be good to at least *consider* what we allow and make sure it's safe. -- Konstantin Osipov, Moscow, Russia