From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2C634469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 20 May 2020 11:31:02 +0300 (MSK)
Date: Wed, 20 May 2020 11:30:23 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200520083023.GC1400@pony.bronevichok.ru>
References: <1589934997.349902287@f427.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1589934997.349902287@f427.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup temporary
	perf images
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hi, Oleg!

generally LGTM, but see my question regarding commit message.

On 03:36 Wed 20 May , Oleg Piskunov wrote:
> 
> 
> - add cleanup after perf docker
>   image preparation (perf_bootstrap job).
> - cleanup perf docker images on execution hosts
>   after perf testing (cleanup stage).
>  
> Closes #5003

There is a best practice to explain 'what' and 'why' in a commit message
body. It is unclear why we should cleanup these images and cannot reuse
existed images.

<snipped>