From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8319C469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 19 May 2020 15:14:46 +0300 (MSK)
Date: Tue, 19 May 2020 15:14:22 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200519121422.2ipko477fonb4363@tkn_work_nb>
References: <cover.1589240001.git.v.shpilevoy@tarantool.org>
 <1c487bc6-4209-d4b4-6d69-1269037121ba@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1c487bc6-4209-d4b4-6d69-1269037121ba@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH msgpuck 1.5/2] Provide more details
 at MP_EXT mp_fprint/snprint()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

>  	case MP_EXT:								\
> -		mp_next(data);							\
> -		PRINTF("undefined");						\
> +	{									\
> +		int8_t type;							\
> +		uint32_t len;							\
> +		mp_decode_ext(data, &type, &len);				\
> +		PRINTF("(extension: type %d, len %u)", (int)type,		\
> +		       (unsigned)len);						\

The header file still contains this comment:

 | /**
 |  * \brief Default MP_EXT serializer into a file. Skips the object,
 |  * ignores all the other arguments, and writes 'undefined'.
 |                                         ^^^^^^^^^^^^^^^^^^
 |  */
 | int
 | mp_fprint_ext_default(FILE *file, const char **data, int depth);

(Same for mp_snprint_ext_default).