From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B4C37469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 19 May 2020 08:00:33 +0300 (MSK)
Date: Tue, 19 May 2020 08:00:31 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200519050031.GA7433@hpalx>
References: <cover.1589799677.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1589799677.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] popen fixes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Alexander, thanks for the patch, I've checked it
MAC with OSX 14 and it passed in different run ways,
LGTM.

On Mon, May 18, 2020 at 02:42:56PM +0300, Alexander Turenko wrote:
> The patchset fixes two problems in the popen implementation and the
> test, which fails testing on Mac OS from time to time.
> 
> https://github.com/tarantool/tarantool/issues/4995
> https://github.com/tarantool/tarantool/issues/4938
> Totktonada/popen-fixes
> 
> Alexander Turenko (2):
>   popen: fix access to freed memory after :close()
>   test: popen: fix popen test 'hang' under test-run
> 
>  src/lib/core/popen.c        |  5 +++++
>  src/lua/popen.c             | 11 +++++++++--
>  test/app-tap/popen.test.lua | 24 +++++++++++++++++++++++-
>  3 files changed, 37 insertions(+), 3 deletions(-)
> 
> -- 
> 2.25.0
>