From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BB5AF469710 for ; Tue, 19 May 2020 00:26:00 +0300 (MSK) Date: Tue, 19 May 2020 00:17:36 +0300 From: Igor Munkin Message-ID: <20200518211736.GF5455@tarantool.org> References: <20200512135052.221379-1-gorcunov@gmail.com> <20200512135052.221379-5-gorcunov@gmail.com> <6c634b97-e9bd-c2eb-0916-c303cd2ccadf@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6c634b97-e9bd-c2eb-0916-c303cd2ccadf@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Oleg Babin Cc: tml Oleg, On 18.05.20, Oleg Babin wrote: > Hi! I'm not sure that we really should do that. Functions with LuaL > prefix is a part of Lua code convention AFAIK. > (https://www.lua.org/manual/5.1/manual.html#4) No, it doesn't relate to Lua code convention (at least to the one you've mentioned). luaL_ is just a custom prefix for functions declared/defined in lauxlib.h header, which is a part of Lua public API. | All functions from the auxiliary library are defined in header file | lauxlib.h and have a prefix luaL_. However this prefix is also used for auxiliary functions provided by Tarantool (e.g luaL_pushcdata). This *might* be an argument for convention saving but it's definitely a weak one for these changes. I see no problems with the renaming Cyrill made within this patch, since it just affects the name of the static global variable. Please also consider the issue[1] that closely relates to the subj. > [1]: https://github.com/tarantool/tarantool/issues/4577 -- Best regards, IM